Conversation
This was referenced Nov 14, 2023
Contributor
Author
|
This is ready to merge and release. Among various cleanup fixes for the native logic, this also switches MacOS AArch64 to use the "stty" adapter that shells out rather than using FFI. This is a fairly big change, but given the ongoing bugs running on this platform, this is a significant improvement in that IRB with Reline works properly again. The remaining bugs in the native FFI console logic still must be fixed on MacOS/AArch64 (and any other platforms). This is a temporary workaround to get users full IRB capability. |
This allows platforms we have not tested to still work without raising an error. See jruby/jruby#8005
This should work largely the same across all backends.
Still having some issues fixing (and finding) the remaining bugs on MacOS on AArch64 (FFI), but the stty version gets IRB working.
* Hide stty-specific IO methods * Improve and factor out stty command error handling * Eliminate verbose syntax warnings
These can be shared with the stty version since raw mode works.
I cannot explain why this is failing in CI. It works locally, and similar code tested in isolation properly rejects the bad keyword argument. For now, re-omitting this.
Contributor
Author
Member
Contributor
Author
|
@hsbt Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cross-platform fixes incoming.