fix breaking specs in CI due to undefined method in ruby MRI < 2.5#29
Merged
hsbt merged 1 commit intoruby:masterfrom Jan 6, 2019
colby-swandale:colby/breaking-ci
Merged
fix breaking specs in CI due to undefined method in ruby MRI < 2.5#29hsbt merged 1 commit intoruby:masterfrom colby-swandale:colby/breaking-ci
hsbt merged 1 commit intoruby:masterfrom
colby-swandale:colby/breaking-ci
Conversation
hsbt
requested changes
Jan 4, 2019
lib/fileutils.rb
Outdated
| Dir.children(path, opts)\ | ||
| .map {|n| Entry_.new(prefix(), join(rel(), n.untaint)) } | ||
|
|
||
| files = begin |
Member
There was a problem hiding this comment.
I prefer to assign from result of if statement directly instead of begin ... end statement.
Member
Author
|
@hsbt Thank you for the feedback, i've updated the PR. |
hsbt
approved these changes
Jan 6, 2019
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Mar 27, 2019
It includes the following updates: * ruby/fileutils#26 * ruby/fileutils#27 * ruby/fileutils#29 * ruby/fileutils#34 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dir.childrenis only available on versions of MRI >= 2.5. This is breaking CI and preventing new PRs from being merged. This was caused by d8c665cThis PR fixes the issue by checking if the method exists, otherwise, use the previous way of getting filenames.