Improve Ractor-compliance #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Dec 7, 2022
| end | ||
|
|
||
| KERNEL_RESPOND_TO = ::Kernel.instance_method(:respond_to?) | ||
| private_constant :KERNEL_RESPOND_TO |
Member
There was a problem hiding this comment.
Would it be enough to Ractor.make_shareable(KERNEL_RESPOND_TO) here?
Author
There was a problem hiding this comment.
I think that unbound methods can't be made shareable right now. When I use make_shareable on KERNEL_RESPOND_TO, I get an error. So I think a workaround is needed for now.
Member
There was a problem hiding this comment.
Ah indeed:
irb(main):001:0> KERNEL_RESPOND_TO = ::Kernel.instance_method(:respond_to?)
=> #<UnboundMethod: Kernel#respond_to?(*)>
irb(main):002:0> Ractor.make_shareable KERNEL_RESPOND_TO
<internal:ractor>:816:in `make_shareable': can not make shareable object for #<UnboundMethod: Kernel#respond_to?(*)> (Ractor::Error)
from (irb):2:in `<main>'
from /home/eregon/.rubies/ruby-3.1.2/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
from /home/eregon/.rubies/ruby-3.1.2/bin/irb:25:in `load'
from /home/eregon/.rubies/ruby-3.1.2/bin/irb:25:in `<main>'
I think it's worth reporting to https://bugs.ruby-lang.org/, could you do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets Delegate avoid using shared data, and it makes sure that methods are defined using shareable Procs. In this way, Delegate's ability to be used within Ractors is increased.