remove a circular require #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If applied, this commit removes some circular `require`s. Prior to this change, we had the following circular `require`s ``` require_relative 'entry' unless defined? Net::LDAP::Entry # dataset require_relative 'dataset' unless defined? Net::LDAP::Dataset # entry ``` This works (both classes need each other in methods), but it's unnecessary, since calling `require` twice does nothing, since `$LOADED_FEATURES` has already been updated. This change moves those `require`s to the toplevel, and removes the `defined?` check. --- No tests were added, since the existing tests passed without issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied, this commit removes some circular
requires.Prior to this change, we had the following circular
requiresThis works (both classes need each other in methods), but it's unnecessary, since calling
requiretwice does nothing, since$LOADED_FEATUREShas already been updated.This change moves those
requires to the toplevel, and removes thedefined?check.No tests were added, since the existing tests passed without issue.