rtrclient: Fix crash on empty ROA array#321
Merged
Brias merged 1 commit intortrlib:masterfrom Feb 18, 2026
Merged
Conversation
Contributor
|
@ydahhrk Many thanks for this detailed and easy to test pull request. 🙏 I only have a few minor requests regarding code style and consistency, then we can merge this PR. |
Brias
requested changes
Feb 9, 2026
When rtrclient's -e argument was included, the mustach interface was always attempting to access the ROA array, even when it was empty. The array can be empty when the server returns a session that contains no prefix PDUs.
Contributor
Author
|
Sorry... not sure what happened there. The commit should be fixed now. |
Brias
previously approved these changes
Feb 13, 2026
Some tests are failing. I will check next week why.
Brias
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When
rtrclient's-eargument was included, the mustach interface was always attempting to access the ROA array, even when it was empty.The array can be empty when the server returns a session that contains no prefix PDUs.
Testing procedure
I left a public server at
fort-testing.dev.lacnic.net:8323.Output before patch:
Output after patch: