Refactor config::get to split off two helper functions#58
Open
elipousson wants to merge 1 commit intorstudio:mainfrom
Open
Refactor config::get to split off two helper functions#58elipousson wants to merge 1 commit intorstudio:mainfrom
config::get to split off two helper functions#58elipousson wants to merge 1 commit intorstudio:mainfrom
Conversation
Split off `load_config` wrapper for `yaml::yaml.load_file` and `eval_config` as internal functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits off two new internal helper functions from
config::get:load_configas a wrapper foryaml::yaml.load_fileandeval_configfor recursive evaluation.Splitting this functionality out of
config::getallows users to avoid the requirement that the config file include a "default" key (per #13) sinceload_config(file) |> eval_config()covers a good part of the functionality ofconfig::get().