Skip to content

fix unit tests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javornikolov merged 2 commits into from
Feb 22, 2016
Merged

fix unit tests #98

javornikolov merged 2 commits into from
Feb 22, 2016

Conversation

@jgebal
Copy link
Contributor

@jgebal jgebal commented Feb 20, 2016

No description provided.

@javornikolov
Copy link
Collaborator

javornikolov commented Feb 20, 2016

Thank you @jgebal! Is that working fine with JRuby (I recall some error message differences in jruby vs mri ruby)?

@jgebal
Copy link
Contributor Author

jgebal commented Feb 20, 2016

did not check...

@jgebal
Copy link
Contributor Author

jgebal commented Feb 21, 2016

Hmmm.
I just tried to run it on JRuby and got a whole lot of exceptions. Not really related to the change.

Java::JavaSql::SQLException: Could not commit with auto-commit set on
oracle.jdbc.driver.PhysicalConnection.commit(oracle/jdbc/driver/PhysicalConnection.java:4439)
oracle.jdbc.driver.PhysicalConnection.commit(oracle/jdbc/driver/PhysicalConnection.java:4486)
java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:606)
RUBY.commit(/home/user/RubymineProjects/ruby-plsql/spec/../lib/plsql/jdbc_connection.rb:65)
RUBY.(root)(/home/user/RubymineProjects/ruby-plsql/spec/plsql/procedure_spec.rb:1848)
ruby.__dash_e__.(root)(-e:1)
ruby.__dash_e__.(root)(ruby/-e:1)

@javornikolov javornikolov mentioned this pull request Feb 21, 2016
Closed
javornikolov
javornikolov reviewed Feb 21, 2016
View reviewed changes
spec/plsql/procedure_spec.rb Outdated
plsql.logoff
end


Copy link
Collaborator

@javornikolov javornikolov Feb 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Formatting] do we need 2 blank lines here?

Copy link
Contributor Author

@jgebal jgebal Feb 21, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgebal jgebal force-pushed the feature/fix_unit_tests_boost_perf_of_ut branch from 7e074d1 to 8b3287e Compare February 22, 2016 00:55
@jgebal
Copy link
Contributor Author

jgebal commented Feb 22, 2016

@javornikolov You think it is OK to merge?

@javornikolov
Copy link
Collaborator

javornikolov commented Feb 22, 2016

@jgebal, yes, I'm going to merge it. Thank you!

javornikolov added a commit that referenced this pull request Feb 22, 2016
@javornikolov
Merge pull request #98 from jgebal/feature/fix_unit_tests_boost_perf_…
d7ea70a 
…of_ut

fix unit tests
@javornikolov javornikolov merged commit d7ea70a into rsim:master Feb 22, 2016
@jgebal jgebal deleted the feature/fix_unit_tests_boost_perf_of_ut branch February 24, 2016 23:18
@javornikolov javornikolov modified the milestone: 0.6.0 Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal improvement

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jgebal @javornikolov