New procedure argument metadata option 'defaulted' #92
Conversation
|
Nice work. |
|
will do |
lib/plsql/procedure.rb
Outdated
There was a problem hiding this comment.
Since which Oracle release do we have this defaulted attribute? What would happen if we run against e.g. 10g?
There was a problem hiding this comment.
Yes, on 10g there's no such column, so I will do like in subprogram_id_column.
|
@gacha : would you mind splitting the test VM setup changes into a separate pull request (seems an independent topic). Thank you! |
bfe8a4a to
c7062e5
Compare
|
Finally got time to finish this, removed the Vagrant change because someone already did that, also added tests. Also I had problems running tests as it's described in Readme, I had to add |
spec/plsql/procedure_spec.rb
Outdated
There was a problem hiding this comment.
Do we need to specify the schema name here hr.?
There was a problem hiding this comment.
I'm wondering about a better name - defaulted_value sounds more like the value itself (21), while we expect the whole expression/clause here.
|
Thank you @gacha, it looks great! I just posted a few cosmetic remarks which I think is good to sort out and we can merge the PR. |
|
Anything else? |
|
Thanks, it looks good to me 👍 @gacha, could you please just squash the two commits into a single one before we merge it. |
Now it is possible to determine if a field has default arguments.
7bdc6be to
110b67c
Compare
|
Done |
|
Nice, I'm merging it... @gacha, thank you very much for your contribution! |
New procedure argument metadata option 'defaulted'
Now it is possible to determine if a field has default arguments.
Reciepe chef/centos-6.6 doesn't exists any more, so updated it to 6.7.
New CentOS image doesn't permit password from dictionary, so changed it
to something else.