Added support for VARCHAR, SIMPLE_INTEGER+subtypes #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@javornikolov Can you review? |
Collaborator
|
Hi @jgebal, |
spec/plsql/procedure_spec.rb
Outdated
Collaborator
There was a problem hiding this comment.
Missing space after , in the list.
7330d08 to
cc53596
Compare
Contributor
Author
|
@javornikolov All comments addressed :) |
Collaborator
|
Thanks, @jgebal. All tests are passing now. In general seems fine to me. I see a few more points to clean up from cosmetic point of view - I'll put a note on them. After that we're ready to squash and merge. |
spec/plsql/variable_spec.rb
Outdated
Collaborator
There was a problem hiding this comment.
Missing space after :
POSITIVEN, SIGNTYPE datatype. Refactored Unit Tests to use shared examples Updated README.md
40f7e4c to
9817dc5
Compare
Collaborator
|
Nice :-) Merging. Thank you @jgebal! |
javornikolov
added a commit
that referenced
this pull request
Jun 18, 2015
Added support for VARCHAR, SIMPLE_INTEGER+subtypes
Contributor
Author
|
It was a pleasure to contribute.
I plan to do some more soon.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for VARCHAR, SIMPLE_INTEGER, NATURAL, NATURALN, POSITIVE, POSITIVEN, SIGNTYPE datatype.
Refactored Unit Tests to use shared examples
Updated README.md