Fix thread safety problem in PLSQL::OCIConnection::Cursor #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem occurred in multithreaded environment with shared state (class variable): OCIException: OCI8::Cursor was already closed. * Fixed by maintaining separate stack of open cursors per thread * Original solution by Author: Nikita Shilnikov <[email protected]> Date: Fri Mar 1 02:31:16 2013 +0400 commit: d363756 source: github.com flash-gordon/ruby-plsql oci_ar_threaded_fix * Later amended to use Thread.current in order to avoid memory leaks
javornikolov
added a commit
that referenced
this pull request
May 9, 2015
Fix thread safety problem in PLSQL::OCIConnection::Cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to resolve #46 (small fix up on top of the original proposal)
Problem occurred in multithreaded environment with shared state (class variable): OCIException: OCI8::Cursor was already closed.
Author: Nikita Shilnikov
Date: Fri Mar 1 02:31:16 2013 +0400
commit: d363756
source: github.com flash-gordon/ruby-plsql oci_ar_threaded_fix