Support oracle 18c #196
Merged
Support oracle 18c #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for opening a pull request. Let me review them. |
koic
added a commit
to koic/ruby-plsql
that referenced
this pull request
Dec 2, 2021
Follow up to rsim#196. This PR suppresses the following `assigned but unused variable` warning. ```console ==> Running specs with ruby version 3.1.0 /home/travis/.rvm/gems/ruby-head/bundler/gems/ruby-plsql-b7f469a72bd7/lib/plsql/procedure.rb:234: warning: assigned but unused variable - object_name ==> Effective ActiveRecord version 7.0.0.alpha2 ``` https://app.travis-ci.com/github/rsim/oracle-enhanced/jobs/550436965
koic
added a commit
to koic/ruby-plsql
that referenced
this pull request
Dec 3, 2021
Follow up to rsim#196. This PR suppresses the following `assigned but unused variable` warning. ```console ==> Running specs with ruby version 3.1.0 /home/travis/.rvm/gems/ruby-head/bundler/gems/ruby-plsql-b7f469a72bd7/lib/plsql/procedure.rb:234: warning: assigned but unused variable - object_name ==> Effective ActiveRecord version 7.0.0.alpha2 ``` https://app.travis-ci.com/github/rsim/oracle-enhanced/jobs/550436965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187
Finally, I have worked out a way to support Oracle 18c and higher. These changes were tested against Oracle 19.9 non-PDB Database and Oracle 12.1. The Oracle metadata catalogs have changed in many ways, so I have separated the implementation in new functions.
Since Oracle 19c has some strange bug with wrong database metadata entries with the test packages in the procedure specs, I have made some declaration changes which are downwards compatible. These wrong metadata entries do not show up in our application which has around 700k lines of PL/SQL code with thousands of type declarations but it seems to be a problem of the dense type declarations and type combinations used in the spec. I have not found any known Oracle issues for that but could reliably reproduce it.
For the maintainability of the code I would still favour dropping support for legacy Oracle and Ruby-Versions which are out-of-support for a number of years now.