Skip to content

Conversation

@jgebal
Copy link
Contributor

@jgebal jgebal commented Feb 24, 2016

Added JUnit Formatter to Gemfile for reporting Unit Tests outcomes onJenkins CI.

@javornikolov
Copy link
Collaborator

Thank you @jgebal , looks good to me. Can we just update the comment message to "imperative present tense" (as per Git guidelines https://git-scm.com/book/ch5-2.html)

@jgebal
Copy link
Contributor Author

jgebal commented Feb 24, 2016

Thanks for the guideline.
Will this do?
"Allow reporting of Unit Tests on Jenkins CI with "Rspec JUnit Formatter"

@jgebal jgebal force-pushed the feature/add_junit_formatter_for_jenkins_ci branch from 7715036 to 1a0d789 Compare February 24, 2016 23:14
@jgebal jgebal changed the title Added JUnit Formatter to Gemfile for reporting Unit Tests outcomes on… Allow reporting of Unit Tests on Jenkins CI with "RspecJunitFormatter" Feb 24, 2016
@javornikolov
Copy link
Collaborator

Looks OK to me now. Thanks! Merging...

javornikolov added a commit that referenced this pull request Feb 25, 2016
…enkins_ci

Allow reporting of Unit Tests on Jenkins CI with "RspecJunitFormatter"
@javornikolov javornikolov merged commit c3bf839 into rsim:master Feb 25, 2016
@jgebal
Copy link
Contributor Author

jgebal commented Feb 25, 2016 via email

@javornikolov
Copy link
Collaborator

I think yes. Also it might be useful to add a note somewhere about setting up ruby-plsql* with Jenkins or other CI servers (I guess it's a common question).

@jgebal
Copy link
Contributor Author

jgebal commented Feb 25, 2016 via email

@javornikolov javornikolov modified the milestone: 0.6.0 Mar 13, 2016
@jgebal jgebal deleted the feature/add_junit_formatter_for_jenkins_ci branch March 13, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants