Skip to content

ci: only run scheduled python bindings generation on main repo#548

Merged
esteve merged 1 commit intoros2-rust:mainfrom
knmcguire:patch-6
Jan 14, 2026
Merged

ci: only run scheduled python bindings generation on main repo#548
esteve merged 1 commit intoros2-rust:mainfrom
knmcguire:patch-6

Conversation

@knmcguire
Copy link
Copy Markdown
Contributor

To prevent the generate python bindings to also run on our forks. It is quite invasive of creating pull requests on all of our forked repos as well.

If this works nicely, let's also add this to all the other CI as well.

But the manual triggering of actions should still work though

Copy link
Copy Markdown
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knmcguire
Copy link
Copy Markdown
Contributor Author

The build CI issues are due to some connections issues of pulling some of the packages. Either you can run it again after a while or trust the process and merge already.

we won't know if it works until next tuesday anyway

@knmcguire
Copy link
Copy Markdown
Contributor Author

Could this be merged? Feel free to run the CI again as those fails were due to a connection issue to the Ubuntu's package archives

@esteve
Copy link
Copy Markdown
Collaborator

esteve commented Jan 4, 2026

@knmcguire I couldn't find the button to rerun the failing CI jobs, I think it's because it had been too long, I don't know. Anyway, I force pushed to your fork to trigger a new CI build, but I didn't change anything.

@knmcguire
Copy link
Copy Markdown
Contributor Author

knmcguire commented Jan 4, 2026

Ah... unfortunately we are hitting that async-lock issue (#561) and also the windows binary download issue (#562) ...

Tomorrow I'll try to figure out if infra has fixed the windows binary issue and send out a fix for that. For the async-lock issue that is something that needs to be discussed within the group (as that requires a rust version update for minimal)

@esteve
Copy link
Copy Markdown
Collaborator

esteve commented Jan 14, 2026

@knmcguire thanks. CI passes finally! 🥳

@esteve esteve merged commit 16aa509 into ros2-rust:main Jan 14, 2026
9 checks passed
@esteve esteve changed the title Only run scheduled python bindings generation on main repo ci: only run scheduled python bindings generation on main repo Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants