[math] missing overloads for addToGlobList #20799
Open
+82
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noticed by makortel in root-project#19645 (comment) name,formula should have an overload not using option, for symmetry with current TF1: TF1(const char *name, const char *formula, Double_t xmin = 0, Double_t xmax = 1, EAddToList addToGlobList = EAddToList::kDefault, bool vectorize = false); TF1(const char *name, const char *formula, Double_t xmin, Double_t xmax, Option_t * option); // same as above but using a string for option These were missed when adding the different overloads on TF2 and TF3
Test Results 22 files 22 suites 3d 17h 47m 25s ⏱️ For more details on these failures, see this check. Results for commit 1ab6d0f. ♻️ This comment has been updated with latest results. |
|
Thanks! |
hageboeck
reviewed
Jan 7, 2026
Member
hageboeck
left a comment
There was a problem hiding this comment.
Hello @ferdymercury,
please have a look at the suggestions below. I think we should make sure that the min max arguments are placed and used consistently.
ferdymercury
commented
Jan 7, 2026
as suggested by hageboeck
hageboeck
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed by @makortel in #19645 (comment)
name,formula should have an overload not using option, for symmetry with current TF1:
These were missed when adding the different overloads on TF2 and TF3