-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Python][UHI] Start introducing UHI serialization #20194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 22 files 22 suites 3d 22h 52m 56s ⏱️ Results for commit ac2177b. ♻️ This comment has been updated with latest results. |
2fab875 to
3b60209
Compare
559690c to
4442d53
Compare
ce1365e to
3adad1b
Compare
3adad1b to
90220a3
Compare
vepadulano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks! A couple of minor comments from my side. As a followup, we'll definitely want to add some docs to the UHI section and possibly a tutorial. That can come later of course, this is also a fresher UHI feature which I believe still needs discussing in general outside of ROOT.
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_th1.py
Outdated
Show resolved
Hide resolved
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_th1.py
Outdated
Show resolved
Hide resolved
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_th2.py
Outdated
Show resolved
Hide resolved
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_th3.py
Outdated
Show resolved
Hide resolved
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_uhi/serialization.py
Show resolved
Hide resolved
90220a3 to
ac2177b
Compare
|
Thanks for the review @vepadulano , and yes docs will come in a later PR |
This Pull request:
This PR introduces the first steps toward enabling UHI serialization for ROOT histograms (see scikit-hep/uhi#167).
It implements
_to_uhi_for ROOT histograms: provides an Intermediate Representation of the histogram described by the UHI schema._from_uhi_classmethod: converts from a UHI histogram to a ROOT histogram.Minimal reproducer: