Fix CI setup#392
Merged
Merged
Conversation
Node 22 ships V8 12.4 which does not have GetPrototypeV2; the old condition was triggered prematurely. Align the cutoff with Nan's SetPrototype guard so V2 is only used on V8 >= 14 (Node 26+).
Contributor
|
FYI, I'm not sure my Claude-assisted fix in #391 is entirely correct. I'm now getting PS: given that this doesn't happen right away and the time it takes varies, I'm thinking that it might be related to garbage collection double-freeing native pointers, or similar. PPS: I only see this on Ubuntu 26 though. The same code works on Ubuntu 24. |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
windows-latest now ships Visual Studio 18 (2026), which node-gyp can't identify (reports version "undefined") and fails its win32 VS-detection gate during configure — even though the real compile uses MINGW gcc. windows-2022 has VS 2022 (v17), which node-gyp recognizes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI setup and update versions.