Skip to content

split Zdivisibility from Znumtheory, deprecate most of Znumtheory#136

Merged
andres-erbsen merged 2 commits into
rocq-prover:masterfrom
andres-erbsen:less-znumtheory
May 10, 2025
Merged

split Zdivisibility from Znumtheory, deprecate most of Znumtheory#136
andres-erbsen merged 2 commits into
rocq-prover:masterfrom
andres-erbsen:less-znumtheory

Conversation

@andres-erbsen
Copy link
Copy Markdown
Collaborator

@andres-erbsen andres-erbsen commented May 3, 2025

@andres-erbsen andres-erbsen force-pushed the less-znumtheory branch 8 times, most recently from 9d1d286 to 65ff9c5 Compare May 4, 2025 16:48
@andres-erbsen andres-erbsen requested a review from proux01 May 4, 2025 17:14
andres-erbsen added a commit to andres-erbsen/mczify that referenced this pull request May 4, 2025
andres-erbsen added a commit to andres-erbsen/CompCert that referenced this pull request May 4, 2025
xavierleroy pushed a commit to AbsInt/CompCert that referenced this pull request May 5, 2025
@proux01
Copy link
Copy Markdown
Contributor

proux01 commented May 6, 2025

According to the last message on the original PR rocq-prover/rocq#19789 (comment) I was just waiting for you to open the PR here (I even did the rebase for you, you just had to click the provided link) and promised to review/merge it quickly. Alas, this was four months ago, I no longer have time for it right now.
So if no one else takes over, feel free to merge if you're happy with it, once CI is green (it seems pretty unhappy right now).

@andres-erbsen
Copy link
Copy Markdown
Collaborator Author

Note that this PR is not the straightforward rebase from january but rather a version adapted to work with the component-dependency-restricted build, including some changes to the component dependencies.

@andres-erbsen

This comment was marked as resolved.

@andres-erbsen andres-erbsen mentioned this pull request May 9, 2025
5 tasks
@andres-erbsen andres-erbsen force-pushed the less-znumtheory branch 3 times, most recently from f7f3d49 to ad26b63 Compare May 10, 2025 11:44
@andres-erbsen
Copy link
Copy Markdown
Collaborator Author

I added a compat require of Znumtheory in ZArith, split up the changelog by category, and changed deprecations to say 9.1.

I intend to merge if CI passes.

@andres-erbsen andres-erbsen merged commit d53a44d into rocq-prover:master May 10, 2025
227 checks passed
@proux01 proux01 added this to the 9.1 milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants