Improve PHP 8.4 test bootstrap compatibility#6
Draft
digitalbase wants to merge 4 commits intorock-symphony:masterfrom
Draft
Improve PHP 8.4 test bootstrap compatibility#6digitalbase wants to merge 4 commits intorock-symphony:masterfrom
digitalbase wants to merge 4 commits intorock-symphony:masterfrom
Conversation
Author
|
Honestly i don't think this should be merged. Wanted to just preserve the state on the fixes it did getting ready for PHP8.4. There are other issues in the propel/phing packages and we need to upgrade rock-symphony first too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare_tests.shfor current Symfony task/composer behaviorsfPropelDatabaseTestContext
This branch focuses on unblocking test execution under local PHP 8.4. It does not fully resolve all remaining legacy vendor/runtime incompatibilities yet (notably old Propel/Phing parser/runtime issues), but it moves the suite past several bootstrap/setup blockers.
Validation
php test/bin/prove.phpwith local PHP 8.4 (/opt/homebrew/opt/php@8.4/bin/php)