Merged
Conversation
The create_deployment_model helper would create the tasks and the deployments. It turns out that (unexpectedly), Syskit deployment models would not hold a reference to the corresponding Syskit task models (it only refers to the orogen objects), and sometimes the syskit models would be garbage collected before they're needed. I never saw this in the wild, but I think it is something that should ultimately be fixed at the deployment level.
g-arjones
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create_deployment_model helper would create the tasks and the
deployments. It turns out that (unexpectedly), Syskit deployment
models would not hold a reference to the corresponding Syskit
task models (it only refers to the orogen objects), and sometimes
the syskit models would be garbage collected before they're needed.
I never saw this in the wild, but I think it is something that
should ultimately be fixed at the deployment level.