🐞 Bug Report, 🤩 Feature Request and ❓ Question issue templates#7
Merged
Conversation
Borda
added a commit
that referenced
this pull request
Apr 14, 2026
[resolve #7] /review finding by sw-engineer (report: .temp/output-review-from-inference-rle-mask-2026-04-14.md): "rle_to_mask uses assert for input validation which can be disabled with python -O; raise ValueError instead..." --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
that referenced
this pull request
Apr 15, 2026
- Move supervision/keypoint/ → src/supervision/keypoint/ so shims are included in built wheels (project uses src layout) - Replace raw DeprecationWarning with warn_deprecated (SupervisionWarnings) in all three shim files for consistent warning behaviour - Fix wrong import path (supervision.utils.deprecation → .internal) and remove unsupported stacklevel arg from warn_deprecated call [resolve #7] Review comment by @copilot (PR #2214): "This warning uses the standard DeprecationWarning..." [resolve #8] Review comment by @copilot (PR #2214): "These deprecation shim modules are added under the top-level supervision/..." --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
that referenced
this pull request
Apr 15, 2026
- Move supervision/keypoint/ → src/supervision/keypoint/ so shims are included in built wheels (project uses src layout) - Replace raw DeprecationWarning with warn_deprecated (SupervisionWarnings) in all three shim files for consistent warning behaviour - Fix wrong import path (supervision.utils.deprecation → .internal) and remove unsupported stacklevel arg from warn_deprecated call [resolve #7] Review comment by @copilot (PR #2214): "This warning uses the standard DeprecationWarning..." [resolve #8] Review comment by @copilot (PR #2214): "These deprecation shim modules are added under the top-level supervision/..." --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to shaun0927/supervision
that referenced
this pull request
Apr 17, 2026
…ocstrings [resolve roboflow#7] /review finding by foundry:doc-scribe (report: .temp/output-review-fix-sinks-slice-list-values-2026-04-17.md) --- Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Borda
added a commit
to shaun0927/supervision
that referenced
this pull request
Apr 17, 2026
The smooth parameter docstring now describes the fallback to raw polyline when fewer than 4 unique anchor points are available. [resolve roboflow#7] /review finding by doc-scribe (report: smooth param docstring omits fallback) --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to shaun0927/supervision
that referenced
this pull request
Apr 17, 2026
Add parametrized test for '.', '', 'subdir/..' — all resolve to the images directory itself, exercising the equality guard that had zero coverage. [resolve roboflow#7] /review finding by qa-specialist (report: .temp/output-review-fix-coco-loader-path-containment-2026-04-17.md): "Branch 1 (equality guard) has zero test coverage" --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
that referenced
this pull request
Apr 22, 2026
- Add test_resize_dispatch_uses_cv2_for_dense: verifies _resize_crop takes the cv2 fallback for a checkerboard mask that exceeds _L3_DENSITY_THRESHOLD - Add TestResizeParallelPath with two tests covering N>=8 masks (triggers ThreadPoolExecutor path): correctness and shape checks [resolve #7] /review finding by qa-specialist (report: .temp/output-review-rle-resize-2026-04-22.md): "No test for density-based dispatch threshold (_L3_DENSITY_THRESHOLD)" [resolve #8] /review finding by qa-specialist (report: .temp/output-review-rle-resize-2026-04-22.md): "No test for resize() with N >= 8 (thread pool code path never exercised)" --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to satishkc7/supervision
that referenced
this pull request
May 19, 2026
…be (report: .reports/review/2026-05-19T10-05-17Z/review-report.md): document silent-degrade contract for preserve_audio - Clarify that missing/failing ffmpeg warns and continues rather than raising - Add install hint for ffmpeg (apt/brew) - Note that audio is truncated to match the processed video duration (-shortest) --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to madhavcodez/supervision
that referenced
this pull request
May 22, 2026
…etections Three additions: - Assert cv2.imwrite return value in _tiny_detection_dataset helper so codec failures produce explicit errors rather than cryptic downstream ones - Fix _tiny_detection_dataset xyxy shape for dets_per_image=0 (was (0,), now (0,4) via reshape — required by Detections validator) - test_save_coco_annotations_annotation_image_id_references_correct_image: verifies every annotation.image_id references a known image id after chaining with a non-default starting_image_id - test_save_coco_annotations_zero_annotation_images: pins behaviour for images with zero detections — image ids advance, annotation list empty [resolve roboflow#6] /review finding by foundry:qa-specialist (report: .reports/review/2026-05-22T18-44-11Z/review-report.md): [resolve roboflow#7] /review finding by foundry:qa-specialist (report: .reports/review/2026-05-22T18-44-11Z/review-report.md): [resolve roboflow#10] @Copilot (gh comment #3290385653): --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to Ace3Z/supervision
that referenced
this pull request
May 27, 2026
Function had no docstring. Document: CLASS_NAME_DATA_FIELD always present and string-dtype in returned data dict (load-bearing invariant for the empty-path fix), 6-tuple return order, and an example showing the dtype guarantee. [resolve roboflow#7] /review finding by foundry:doc-scribe (report: .reports/review/2026-05-27T06-06-27Z/review-report.md) --- Co-authored-by: Claude Code <noreply@anthropic.com>
Borda
added a commit
to kounelisagis/supervision
that referenced
this pull request
Jun 8, 2026
- [resolve roboflow#5] oriented_box_non_max_suppression + oriented_box_non_max_merge: add Examples: doctest blocks (project convention for all public APIs). Challenge: evidence=VALID suggestion=VALID resolution=as-suggested - [resolve roboflow#7] oriented_box_iou_batch: update summary/Returns from "Pairwise IoU" to overlap_metric-aware wording, matching box_iou_batch convention. Challenge: evidence=VALID suggestion=VALID resolution=as-suggested - [resolve roboflow#8] oriented_box_iou_batch + public entry-points: add ndim/shape validation before reshape to catch flat (N,8) and wrong-ndim inputs early. Challenge: evidence=VALID suggestion=VALID resolution=as-suggested - [resolve roboflow#9] oriented_box_non_max_merge: add assert 0 <= iou_threshold <= 1, matching the guard present on oriented_box_non_max_suppression and siblings. Challenge: evidence=VALID suggestion=VALID resolution=as-suggested [resolve group] PR roboflow#2303 — items 5, 7, 8, 9 --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Borda
added a commit
that referenced
this pull request
Jun 16, 2026
- [resolve #7] add test_wait_key_returns_none_when_no_window — tests fix #6 (early return when no window and queue empty) - add test_wait_key_returns_none_when_closed_mid_wait — tests interaction of fix #5 + fix #9 (close mid-wait clears queue, wait_key returns None) - add test_close_clears_key_queue — tests fix #5 (_key_queue cleared on close) - collapse two structurally-identical show() error-path tests into one parametrized test (PT006-compliant tuple first arg) --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Borda
added a commit
to RubenHaisma/supervision
that referenced
this pull request
Jul 1, 2026
…ocstring - Broaden param types: `list[list[float]]` → `Sequence[Sequence[float]]`, `list[bool]` → `Sequence[bool]` (item roboflow#8) - Add `from collections.abc import Callable, Sequence` import - Add `Note:` block warning callers that this function uses `[x, y, w, h]` (COCO convention) while all sibling batch-IoU functions use xyxy (item roboflow#1) - Document NaN propagation behaviour in the Note block (item roboflow#7) - Fix `Returns` section: replace internal names `dt`/`gt` with public param names `boxes_detection`/`boxes_true`; add row/column orientation description (item roboflow#3) --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Jul 3, 2026
…ring - Remove "Legacy" from TestMeanAveragePrecisionBackgroundFalsePositives docstring — from_tensors is the active tensor constructor, not deprecated - Add N=0 background-image contract to targets arg description in from_tensors docstring (empty array = all predictions are false positives) - Add docstring example demonstrating that predictions on a background image produce map50=0.0 (covers new empty-stats code path) - Fix Returns section: add MeanAveragePrecision type prefix per Google style [resolve #3] /review finding by foundry:doc-scribe (report) [resolve #5] /review finding by foundry:doc-scribe (report) [resolve #7] /review finding by foundry:doc-scribe (report) [resolve #8] /review finding by foundry:doc-scribe (report) --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Borda
added a commit
to mvanhorn/supervision
that referenced
this pull request
Jul 20, 2026
[resolve group] PR roboflow#2374 — items 1, 2, 3, 7 Detection_area's dense-mask branch now delegates to the shared count_mask_pixels SIMD-popcount helper instead of a duplicated np.count_nonzero(axis=(1,2)) reduction, restoring the ~6x fast path also used by metrics.utils.object_size (item roboflow#1). Relocates detection_area/detection_iou from the pure-array detection/utils/ package to detection/geometry_dispatch.py, since both consume Detections objects rather than raw arrays — this also resolves the module-name collision with the top-level supervision.geometry package (item roboflow#2, item roboflow#7's module-rename part). Documents detection_iou's shared-geometry, box-IoU-last-resort fallback and its asymmetry vs detection_area's per-operand dispatch (item roboflow#3). Renames detection_iou's detections_true/detections_detection params to detections_a/detections_b — the sole caller passes two peer merge candidates with no true/pred relationship (item roboflow#7's param-rename part). --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Borda
added a commit
to mvanhorn/supervision
that referenced
this pull request
Jul 20, 2026
[resolve group] PR roboflow#2374 — items 4, 5, 7 Splits the changelog bullet that fused the merge-IoU bugfix with the unrelated mask-area perf change into two, names the affected APIs, adds the PR link, and drops the "batched reduction" framing that mischaracterized a measured regression as an improvement (item roboflow#4). Restores the blank line before ### Added that this PR's diff had removed (item roboflow#7's changelog part). Rewords the confusing filter_detections.md sentence so "if oriented-box coordinates are present" reads as a condition rather than the data field acting as the sentence's subject (item roboflow#5). --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Borda
added a commit
to Ace3Z/supervision
that referenced
this pull request
Jul 21, 2026
Add `-> None` return annotations to 3 prefetch tests for consistency with the rest of the file (items roboflow#5, roboflow#6, roboflow#7). Tighten the decode-error test to assert RuntimeError specifically (not the tautological `(Exception, RuntimeError)` tuple) plus its `__cause__` chain (item roboflow#8). Add 4 missing prefetch-path tests: negative prefetch raises ValueError, stride+early-termination combo, consumer-exception-in-loop thread cleanup, and reader-outlives-join bounded-close behavior (item roboflow#13). [resolve roboflow#5,roboflow#6,roboflow#7,roboflow#8,roboflow#13] PR roboflow#2273 — Copilot (gh) + foundry:qa-specialist (review): annotation nits, exception-type test tightening, missing prefetch test coverage --- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description