Conversation
- Removed `convert_to_ipynb.sh` script and standalone `.py` demo files. - Added `docs/notebooks/compact-mask-sam3.ipynb` showcasing new features (`sv.CompactMask` and `sv.Detections.from_sam3`) introduced in version `0.28.0`.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2240 +/- ##
=======================================
Coverage 78% 78%
=======================================
Files 66 66
Lines 8347 8347
=======================================
Hits 6475 6475
Misses 1872 1872 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up legacy notebook tooling/content in the repository as part of the shift toward maintaining demos as committed Jupyter notebooks (not .py percent-format sources + conversion scripts).
Changes:
- Removed the legacy Jupytext conversion helper script (
notebooks/convert_to_ipynb.sh). - Removed the old percent-format notebook source for the 0.28.0 release demo (
notebooks/release-demo_0-28.py).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| notebooks/release-demo_0-28.py | Deletes the old percent-format demo source that previously lived under notebooks/. |
| notebooks/convert_to_ipynb.sh | Deletes the helper script that batch-converted notebooks/*.py to .ipynb. |
Comments suppressed due to low confidence (2)
notebooks/release-demo_0-28.py:1
- Removing
notebooks/release-demo_0-28.py(and the entirenotebooks/directory) makes the existing Colab link indocs/notebooks/compact-mask-sam3.ipynbpoint to a non-existent path (.../blob/develop/notebooks/release-demo_0-28.ipynb). Please update that notebook’s Colab URL to the new location (likelydocs/notebooks/compact-mask-sam3.ipynb) or add an equivalent notebook at the old path to avoid a broken link.
notebooks/convert_to_ipynb.sh:1 - PR description only mentions removing
convert_to_ipynb.sh, but this PR also deletesnotebooks/release-demo_0-28.py(and effectively removes thenotebooks/folder). Please update the PR description to reflect the full scope (e.g., migration/removal of the release demo source) so reviewers understand the impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the
convert_to_ipynb.shscript from thenotebooksdirectory. This script was previously used to convert Python files to Jupyter notebook format using Jupytext.convert_to_ipynb.shscript, which automated the conversion of.pyfiles to.ipynbnotebooks using Jupytext.