Skip to content

chore(notebooks): migrate demo scripts to Jupyter notebooks#2240

Merged
Borda merged 2 commits into
developfrom
add/ntb
Apr 30, 2026
Merged

chore(notebooks): migrate demo scripts to Jupyter notebooks#2240
Borda merged 2 commits into
developfrom
add/ntb

Conversation

@Borda

@Borda Borda commented Apr 30, 2026

Copy link
Copy Markdown
Member

This pull request removes the convert_to_ipynb.sh script from the notebooks directory. This script was previously used to convert Python files to Jupyter notebook format using Jupytext.

  • Removed the convert_to_ipynb.sh script, which automated the conversion of .py files to .ipynb notebooks using Jupytext.

- Removed `convert_to_ipynb.sh` script and standalone `.py` demo files.
- Added `docs/notebooks/compact-mask-sam3.ipynb` showcasing new features (`sv.CompactMask` and `sv.Detections.from_sam3`) introduced in version `0.28.0`.
Copilot AI review requested due to automatic review settings April 30, 2026 21:41
@Borda Borda requested a review from SkalskiP as a code owner April 30, 2026 21:41
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Borda Borda added the enhancement New feature or request label Apr 30, 2026
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78%. Comparing base (87b1b86) to head (e2ac665).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2240   +/-   ##
=======================================
  Coverage       78%     78%           
=======================================
  Files           66      66           
  Lines         8347    8347           
=======================================
  Hits          6475    6475           
  Misses        1872    1872           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up legacy notebook tooling/content in the repository as part of the shift toward maintaining demos as committed Jupyter notebooks (not .py percent-format sources + conversion scripts).

Changes:

  • Removed the legacy Jupytext conversion helper script (notebooks/convert_to_ipynb.sh).
  • Removed the old percent-format notebook source for the 0.28.0 release demo (notebooks/release-demo_0-28.py).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
notebooks/release-demo_0-28.py Deletes the old percent-format demo source that previously lived under notebooks/.
notebooks/convert_to_ipynb.sh Deletes the helper script that batch-converted notebooks/*.py to .ipynb.
Comments suppressed due to low confidence (2)

notebooks/release-demo_0-28.py:1

  • Removing notebooks/release-demo_0-28.py (and the entire notebooks/ directory) makes the existing Colab link in docs/notebooks/compact-mask-sam3.ipynb point to a non-existent path (.../blob/develop/notebooks/release-demo_0-28.ipynb). Please update that notebook’s Colab URL to the new location (likely docs/notebooks/compact-mask-sam3.ipynb) or add an equivalent notebook at the old path to avoid a broken link.
    notebooks/convert_to_ipynb.sh:1
  • PR description only mentions removing convert_to_ipynb.sh, but this PR also deletes notebooks/release-demo_0-28.py (and effectively removes the notebooks/ folder). Please update the PR description to reflect the full scope (e.g., migration/removal of the release demo source) so reviewers understand the impact.

@Borda Borda merged commit d8a2548 into develop Apr 30, 2026
27 checks passed
@Borda Borda deleted the add/ntb branch April 30, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants