extract composable riverdbtest.TestTxWithDriver helper #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
reviewed
Sep 30, 2025
eb7b19e to
05788c5
Compare
The existing `TestTxPgx` forced a specific non-Pro driver while also holding useful internal logic around setting a default search path. To make this more reusable, expose a far more flexible `TestTxPgxDriver` variant (used by `TestTxPgx`) which takes a custom driver, allows custom opts, and returns both the tx and schema—all while still setting the default `search_path` so that others can avoid reimplementing those parts.
05788c5 to
08e8db0
Compare
brandur
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
TestTxPgxforced a specific non-Pro driver while also holding useful internal logic around setting a default search path. To make this more reusable, expose a far more flexibleTestTxWithDrivervariant (used byTestTxPgx) which takes a custom driver, allows custom opts, and returns both the tx and schema—all while still setting the defaultsearch_pathso that others can avoid reimplementing those parts.Being leveraged by riverqueue/riverui#435.