Skip to content

Update api_response.py#62

Closed
LohithNarayan wants to merge 1 commit intoringcentral:masterfrom
LohithNarayan:patch-5
Closed

Update api_response.py#62
LohithNarayan wants to merge 1 commit intoringcentral:masterfrom
LohithNarayan:patch-5

Conversation

@LohithNarayan
Copy link
Contributor

Code change from
# message = message + ' (and additional error happened during JSON parse: ' + e.message + ')'

message = message + ' (and additional error happened during JSON parse: ' + str(e) + ')'

n Python 3.x and modern versions of Python 2.x use except Exception as e instead of except Exception, e:

Code change from 
            # message = message + ' (and additional error happened during JSON parse: ' + e.message + ')'
 <to>
             message = message + ' (and additional error happened during JSON parse: ' + str(e) + ')'

n Python 3.x and modern versions of Python 2.x use except Exception as e instead of except Exception, e:
@LohithNarayan LohithNarayan mentioned this pull request Jun 2, 2023
@tylerlong
Copy link
Contributor

tylerlong commented Jun 2, 2023

n Python 3.x and modern versions of Python 2.x use except Exception as e instead of except Exception, e:

I don't quite understand this sentence. And you didn't change except Exception as e or except Exception, e.

Since we are trying to fix an issue of fax sending(#54). We need some testing code (either unit tests or a separate demo project) to verify that fax is working.

@tylerlong
Copy link
Contributor

Since #64 is working fine. Is this PR still necessary?

@tylerlong tylerlong closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants