Skip to content

fix half-way commit text#767

Open
groverlynn wants to merge 3 commits into
rime:masterfrom
groverlynn:commit_text
Open

fix half-way commit text#767
groverlynn wants to merge 3 commits into
rime:masterfrom
groverlynn:commit_text

Conversation

@groverlynn

Copy link
Copy Markdown
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Fix a bug when toggle ascii mode by commit_text while the input segment of the selected candidate is shorter than the complete input (i.e. there are unsegmented raw input beyond the current segment of selected candidate), nothing gets committed at all.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@WhiredPlanck

Copy link
Copy Markdown
Contributor

@groverlynn Please squash your commits.

@groverlynn

groverlynn commented Nov 27, 2023

Copy link
Copy Markdown
Contributor Author

@groverlynn Please squash your commits.

@WhiredPlanck Just did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants