fix: rilltime syntax in comparison time range in citation urls#9478
Draft
AdityaHegde wants to merge 3 commits into
Draft
fix: rilltime syntax in comparison time range in citation urls#9478AdityaHegde wants to merge 3 commits into
AdityaHegde wants to merge 3 commits into
Conversation
d8044db to
4124b7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM can use rill time for relative time ranges. Since backend supports it in comparison time range as well, it can use it in comparison as well. But UI doesnt support rill time, leading to removal of comparison all together.
One solution is to resolve the time range during mapping. But since these are relative time ranges the data analysed by llm and the data in the link wont match. The problem with converting to custom is we wont have the watermark history of the metrics view to resolve against.
Checklist: