Edit a clock entry's description from its popup#240
Merged
Conversation
In the Clocks table a long description opened a read-only expand viewer (ContentPopup), while notes opened the editable NotesBubble -- so the two indicators in the same row behaved differently. Point the description at the same editable NotesBubble (text-icon variant) so it opens the Preview/Write dialog and saves the description, matching the notes bubble next to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In the Clocks table, a long clock-entry description opened a read-only expand viewer (
ContentPopup, the diagonal-arrows icon), while the notes in the same row opened the editableNotesBubble. Two indicators side by side that behaved differently.Fix
Point the long-description indicator at the same editable
NotesBubble(text-icon variant). Clicking it now opens the Preview/Write dialog and saves the description viaupdateClockEntry, matching the notes bubble next to it. The icon shows only when the description is long, as before.Acceptance
tsc+pnpm buildclean.