Removes use of deprecated Buffer constructor#66
Closed
skibz wants to merge 4 commits intoretailnext:masterfrom
skibz:fix-buffer-deprecation-warnings-1
Closed
Removes use of deprecated Buffer constructor#66skibz wants to merge 4 commits intoretailnext:masterfrom skibz:fix-buffer-deprecation-warnings-1
skibz wants to merge 4 commits intoretailnext:masterfrom
skibz:fix-buffer-deprecation-warnings-1
Conversation
Contributor
Author
|
Certainly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the use of buffers to be in line with current standards.
The biggest upside is that buffers get zero-filled automatically when allocating them with
Buffer.alloc, so we get to remove some manual zeroing and zero padding operations throughout the library.I suppose the change I'm proposing here is no bueno if there's a desire to continue supporting users who are running Node versions prior to v5.10.0 (which is when
Buffer.alloc,Buffer.from, and friends were introduced) without adding a nastyprocess.versionconditional or something.Really hoping that it's unlikely people still use such old versions of Node, though. Node 5 was almost an eternity ago... 🙈