Skip to content

fix(render): reactDOMServer import on browser and some bundlers #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabrielmfern merged 3 commits into from
May 7, 2025
Merged

fix(render): reactDOMServer import on browser and some bundlers #2221

gabrielmfern merged 3 commits into from
May 7, 2025

Conversation

@MendyLanda
Copy link
Contributor

@MendyLanda MendyLanda commented May 6, 2025 •
edited by gabrielmfern
Loading

Meant for #1953
All current tests are passing. this also progresses #2176

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 039ea43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@react-email/render Patch
@react-email/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025

@MendyLanda is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@MendyLanda
Copy link
Contributor Author

MendyLanda commented May 6, 2025

@gabrielmfern for your review, thank you!

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/render@2221

commit: c5926dc

@MendyLanda MendyLanda mentioned this pull request May 6, 2025
Closed
gabrielmfern
gabrielmfern approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@gabrielmfern gabrielmfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Let's try it out

@gabrielmfern gabrielmfern merged commit 57ddfd9 into resend:canary May 7, 2025
2 of 6 checks passed
@MendyLanda MendyLanda deleted the import-fix branch May 7, 2025 10:08
gabrielmfern added a commit that referenced this pull request May 9, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
42a640e 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 9, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
de0811d 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 12, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
0405e2b 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 12, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
88eaab8 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 13, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
c6c03a4 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 13, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
bb887ea 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 13, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
460ece3 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 13, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
fcb6347 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 14, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
6eef157 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
5578d50 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
5c1d9c6 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
101db66 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
28061db 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
80cd9db 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 20, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
6200ddc 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 20, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
d8ee381 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request May 28, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
01ab5d3 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 3, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
2bb283c 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 4, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
5d836fa 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 10, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
4174925 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 10, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
e141194 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 10, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
b38d05f 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 16, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
81e646f 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 24, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
94a5b08 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 24, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
96c5453 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 24, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
24d6ff7 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 25, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
1b0df3d 
Co-authored-by: gabriel miranda <[email protected]>
@Tstassin Tstassin mentioned this pull request Jun 26, 2025
Open
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
0f41794 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
b4d245f 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
97d1668 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
f8391a0 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
48f7fda 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
3ae541b 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jun 30, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
9ea908e 
Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern added a commit that referenced this pull request Jul 3, 2025
@MendyLanda @gabrielmfern
fix(render): reactDOMServer import on browser and some bundlers (#2221)
3ef2895 
Co-authored-by: gabriel miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielmfern gabrielmfern gabrielmfern approved these changes

Assignees

No one assigned

Labels

Package: @react-email/render

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MendyLanda @gabrielmfern