Add Rubocop#43
Merged
Merged
Conversation
Member
|
@aliaksandr-trush can you plz review it? |
Member
Author
|
Rebased PR to resolve conflicts. |
Contributor
|
Could you update travis.yml to run rubocop task on PR creating? |
Member
Author
|
@aliaksandr-trush Travis by default runs a rake task that was changed in this PR to run Rubocop rake task. |
aliaksandr-trush
approved these changes
Jun 20, 2019
aliaksandr-trush
left a comment
Contributor
There was a problem hiding this comment.
Fine. Lets move to the next level of code quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Rubocop.
TODO file was autogenerated using
--auto-gen-config. This is a recommended approach for introducing Rubocop to existing projects without fixing hundreds of offenses in a single PR. Later on these offences can be fixed one by one.Also Rubocop will be run in CI.