Refactor internal only flag #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 16 files 36 suites 0s ⏱️ Results for commit 047481a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had the
--dmagic-hashflag which allowed parsing the hash character in#in identifiers. This was used to mark internal identifiers in such a way that they cannot clash with any identifiers written by the user. The primary use was to re-parse generated code (e.g. which might be produced during rewrite passes) for debugging reasons, like to type-check intermediate rewrites.However, it was used for some other internal constructs, and worse, was actively suggested in the error message as a way to work around an error that would appear when such internal constructs appeared (which were only intended as intermediates during lowering passes).
This commit renames the flag to
--dallow-internalto better reflect all its usages, and the error messages from these constructs now provide no indication there is any way to avoid the error.