Further formatting improvements #1536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file makes two main improvements to the formatter. First and most importantly, it adds an AST diff check formatting. This means that if the syntax tree differs in any way (other than some minor permitted differences) after reformatting, this raises an error.
Secondly, we now preserve lined up match statements where possible, so in something like:
The extra spaces after
0and_will be preserved, allowing the=>to remain lined up. This happens when we detect that all the match expressions were lined up in the original source. This heuristic likely needs some tweaking to find the correct balance.