Add support for passing options to remark-rehype#669
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
wooorm
reviewed
Jan 14, 2022
wooorm
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for working on this. It looks wonderful.
I had been holding off on this because it unfortunately is a breaking change (footnotes generate different output now).
2 ideas for improving this PR:
wooorm
reviewed
Jan 17, 2022
wooorm
approved these changes
Jan 17, 2022
remark-rehype options passthroughremark-rehype
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks @peolic, released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This PR updates
remark-rehypeto v10, and adds options passthrough toremark-rehype.This is to enable new options such as
clobberPrefix, which is needed when rendering more than one Markdown document on a page (e.g. comments).Attempted to follow the guidelines and current code structure as much as I could.