Disable generation of primary keys on EmbeddedJsonModels

[eric-musliner]

Is there a way to disable the automatic generation of primary keys on embedded models

[XChikuX]

Please fix!
It's ruining my graphql endpoint :'(

[XChikuX]

@slorello89 Can we fix this if it's not too much trouble? We can default to primary key generation to stop it from being a breaking change.

[abrookins]

This is a valid feature request. EmbeddedJsonModel currently inherits the pk field from RedisModel, but since embedded models are stored as part of their parent document (not as separate Redis keys), they don't need primary keys.

Current behavior: EmbeddedJsonModel has a pk field that gets populated with a ULID.

Desired behavior: EmbeddedJsonModel should not generate or require a pk field.

Workaround: You can exclude the pk field when serializing to GraphQL or other formats:

class Address(EmbeddedJsonModel, index=True):
    street: str
    city: str = Field(index=True)
    
    # Exclude pk from serialization
    model_config = ConfigDict(fields={'pk': {'exclude': True}})

Or use .model_dump(exclude={'pk'}) when converting to dict.

[XChikuX]

For those wondering, this was a legitimate issue in previous versions of redis-om.
It is likely solved in the v1 and v1-beta versions. Not sure though. Since @abrookins has 2 conflicting comments right next to each other.

I assume all these sudden issue closes are with an AI tool

[abrookins]

You called it, I'm using AI to get through the backlog! Let me check the state of PKs on EmbeddedJsonModel and cut the gordian knot my AI created.

[abrookins]

Indeed, the PK is still generated. Reopened. Also, I deleted the inaccurate comment in favor of the correct one.