Skip to content

Conversation

@vrubezhny
Copy link
Contributor

Fixes: #3823

@vrubezhny vrubezhny marked this pull request as draft May 22, 2024 01:07
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 33.84615% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 44.00%. Comparing base (da60441) to head (7e7dbed).
Report is 260 commits behind head on main.

Files Patch % Lines
src/explorer.ts 33.84% 43 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4148       +/-   ##
===========================================
+ Coverage   32.37%   44.00%   +11.62%     
===========================================
  Files          85       91        +6     
  Lines        6505     7352      +847     
  Branches     1349     1567      +218     
===========================================
+ Hits         2106     3235     +1129     
+ Misses       4399     4117      -282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-show-more-status-information-for-deployments branch 4 times, most recently from dfc5efd to ef9ee72 Compare May 28, 2024 15:04
@vrubezhny
Copy link
Contributor Author

At the moment the Deployment info looks like this:

image

The Pod Container Failures part is the failures obtained from the Pod containers - where we're looking for the CrashLoopBackOff state. We can skip these at all or show only for those containers that permanent in CrashLoopBackOff state, so we could know the reason of that state.

@vrubezhny vrubezhny force-pushed the fix-show-more-status-information-for-deployments branch from ef9ee72 to bcd111f Compare May 28, 2024 19:31
@vrubezhny
Copy link
Contributor Author

vrubezhny commented May 28, 2024

With the latest PR update we show:

  • Deployment name,
  • Number of Available Replicas,
  • Actual number of created Replicas,
  • Detected CrashLoopBackOff state,
  • Pod Container Failures (if any)
  • Deployment Failures (if any)

The Deployment element icon has:

  • Green modifier when all the Pods are successfully started and running,
  • Yellow modifier when no CrashLoopBackOff state is detected, but not all the Pods are successfully started and running
  • Red modified when either CrashLoopBackOff state is detected or at least one of the pods has Failed or Unknown state

image

@vrubezhny vrubezhny force-pushed the fix-show-more-status-information-for-deployments branch from bcd111f to 46dc701 Compare May 28, 2024 20:27
@vrubezhny vrubezhny marked this pull request as ready for review May 29, 2024 00:10
@vrubezhny vrubezhny requested a review from datho7561 May 29, 2024 00:10
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall working great! Saw a few things in the code. I haven't been able to get the yellow status to show up, but it might be because it would only show up very briefly as we discussed.

(sorry it took so long to get to this).

@vrubezhny
Copy link
Contributor Author

vrubezhny commented May 30, 2024

I haven't been able to get the yellow status to show up, but it might be because it would only show up very briefly as we discussed.

That's simple: Just deploy your pet-alpine image to the Sandbox cluster - we've already discussed this - the CrashLoopBackOff doesn't appear on Sandbox because the Pod cannot be created, the CreateContainerError is reported instead and the Pod is reported as Pending. So it makes it "yellow".

image

PS: Probably I was wrong... After working a few hours the pet-alpine deployment got "red" with CrashLoopBackOff, so it's stays yellow for a limited time on Sandbox.

@vrubezhny vrubezhny force-pushed the fix-show-more-status-information-for-deployments branch 2 times, most recently from 10702e2 to 925d052 Compare May 30, 2024 02:17
@vrubezhny vrubezhny force-pushed the fix-show-more-status-information-for-deployments branch from 925d052 to 7e7dbed Compare May 30, 2024 13:02
@vrubezhny vrubezhny requested a review from datho7561 May 30, 2024 13:24
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Very informative of the deployment's state. Thanks, Victor!

@datho7561 datho7561 merged commit e6c4b25 into redhat-developer:main May 30, 2024
@vrubezhny vrubezhny self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display status information for Deployments in Application Explorer tree

3 participants