Skip to content

coerce field and form arguments in export_records()#269

Merged
pwildenhain merged 5 commits into
redcap-tools:masterfrom
ugGit:master
Jun 28, 2023
Merged

coerce field and form arguments in export_records()#269
pwildenhain merged 5 commits into
redcap-tools:masterfrom
ugGit:master

Conversation

@ugGit
Copy link
Copy Markdown
Contributor

@ugGit ugGit commented Jun 27, 2023

Implements #262.

Change the expected argument type from List[str] to Union[List[str], str] and coerce if required the argument from str to List[str] before starting the processing.

@ugGit
Copy link
Copy Markdown
Contributor Author

ugGit commented Jun 27, 2023

@pwildenhain anything for me left to do such that the CI passes?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2023

Codecov Report

Merging #269 (90f2f9e) into master (a507d1a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          568       572    +4     
=========================================
+ Hits           568       572    +4     
Impacted Files Coverage Δ
redcap/methods/records.py 100.00% <100.00%> (ø)

Copy link
Copy Markdown
Collaborator

@pwildenhain pwildenhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻👏🏻

@pwildenhain pwildenhain merged commit 83c2826 into redcap-tools:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants