Skip to content

Add request_kwargs to be passed during API requests#251

Merged
pwildenhain merged 4 commits into
redcap-tools:masterfrom
ugGit:master
Feb 21, 2023
Merged

Add request_kwargs to be passed during API requests#251
pwildenhain merged 4 commits into
redcap-tools:masterfrom
ugGit:master

Conversation

@ugGit
Copy link
Copy Markdown
Contributor

@ugGit ugGit commented Dec 15, 2022

Passing request_kwargs during instantiation of Project() to control how API requests are performed later on.

More detail to the use case and motivation is given here: closes #249

@ugGit ugGit mentioned this pull request Feb 20, 2023
Copy link
Copy Markdown
Collaborator

@pwildenhain pwildenhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to get this merged, thanks for following up on this! I'll see what's going on with the CI, probably a styling/linking issue

@pwildenhain
Copy link
Copy Markdown
Collaborator

Can you review and merge ugGit#1
Then the CI should pass here

@ugGit
Copy link
Copy Markdown
Contributor Author

ugGit commented Feb 21, 2023

Sure, all good!

@pwildenhain pwildenhain changed the title allow passing kwargs to perform API requests Add request_kwargs to be passed during API requests Feb 21, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2023

Codecov Report

Merging #251 (361c600) into master (bac8a53) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          702       709    +7     
=========================================
+ Hits           702       709    +7     
Impacted Files Coverage Δ
redcap/request.py 100.00% <ø> (ø)
redcap/methods/base.py 100.00% <100.00%> (ø)

@pwildenhain pwildenhain merged commit c003da8 into redcap-tools:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Setup of Proxy

2 participants