Add _complete fields to payload when requesting survey fields.#149
Merged
Conversation
…This is probably a bad idea, as I believe that these fields also exist for non-survey forms, but there's more work needed here.
pwildenhain
reviewed
May 12, 2021
Collaborator
pwildenhain
left a comment
There was a problem hiding this comment.
Really great find! This has plagued me with several projects. Just one clarification on the usage of list.extend
Co-authored-by: pwildenhain <35195136+pwildenhain@users.noreply.github.com>
Collaborator
|
thanks very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having access to _complete fields is very helpful when processing data from projects with a lot of forms. I have tested this against several projects and it doesn't seem to cause problems, although more testing is a good idea.