Add support for collecting frame information via callbacks.#11
Open
denravonska wants to merge 2 commits intored-rocket-computing:masterfrom
Open
Add support for collecting frame information via callbacks.#11denravonska wants to merge 2 commits intored-rocket-computing:masterfrom
denravonska wants to merge 2 commits intored-rocket-computing:masterfrom
Conversation
In addition to the previous API where the caller provided a buffer and a size, it's now possible to instead proviced a callback and a context. This allows the caller to use their own data structures without having to allocate an additional set of objects to pass to backtrace. The old API is still intact but has internally been rewritten to also use the callback mechanisms. Note that this does increase the stack strain a bit as each frame has to go through the callback. Additionally, this also adds support for traversing a frame provided by the user, with or without callbacks). Closes red-rocket-computing#10
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the previous API where the caller provided a buffer and a size, it's now possible to instead proviced a callback and a context. This allows the caller to use their own data structures without having to allocate an additional set of objects to pass to backtrace.
The old API is still intact but has internally been rewritten to also use the callback mechanisms. Note that this does increase the stack strain a bit as each frame has to go through the callback.
Additionally, this also adds support for traversing a frame provided by the user, with or without callbacks).
Let me know if it's unclear, needs comments or is outright useless.
Tested on Cortex M33 using
backtrace_unwind_from_frame_cb.Closes #10