Skip to content

Conversation

@maximilianfalco
Copy link
Contributor

@maximilianfalco maximilianfalco commented Dec 6, 2025

PR App Fix RM-XYZ

🧰 Changes

We were seeing a weird minor regression when publishing the new mdxish engine. The new engine used mdast-util-mdx-expression v2.0.1 instead of v2.0.0 which was used as a dependency for the old mdx engine (via remarkMdx if not mistaken). While the mdx pipeline remained untouched, using v2.0.1 in mdxish unintentionally caused the old mdx engine to also use this newer version... this introduced a slight bug (Im not sure if this was intentional) where it would indent expressions, including JSX comments when de- or serializing.

What would usually be something like

{/*

## Hey-o

*/}

would become

{/*

  ## Hey-o

  */}

This is a short demo showcase of the bug:

Screen.Recording.2025-12-06.at.17.54.17.mov

Ive managed to trace the origin of this behaviour to this commit WITHIN the plugin library itself. Reverting back to v2.0.0 seems to work for now. Ive added a check against this to make sure this does not happen in the future.

Important

We need to make sure future work regarding mdx or mdxish uses the correct v2.0.0 version of mdast-util-mdx-expression

🧬 QA & Testing

Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer that such a minor bump would futz with formatting like that; alas…

@rafegoldberg rafegoldberg merged commit 280eed2 into readmeio:next Dec 8, 2025
6 checks passed
rafegoldberg pushed a commit that referenced this pull request Dec 8, 2025
## Version 11.8.1
### 🛠 Fixes & Updates

* downgrade `mdast-util-mdx-expression` ([#1251](#1251)) ([280eed2](280eed2))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v11.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants