Skip to content

Enable word-spacing in RTL #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayPanoz merged 2 commits into from
Nov 6, 2024
Merged

Enable word-spacing in RTL #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c52e951
Enable word-spacing in RTL
JayPanoz Nov 6, 2024
3001634
Update dist
JayPanoz Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion css/dist/ReadMe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ Finally, page progression is impacted:
Disabled user settings:

- `hyphens`;
- `word-spacing`;
- `letter-spacing`.

Added user settings:
Expand Down
2 changes: 1 addition & 1 deletion css/dist/ReadiumCSS-after.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/ReadiumCSS-before.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/ReadiumCSS-default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-horizontal/ReadiumCSS-after.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-horizontal/ReadiumCSS-before.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-horizontal/ReadiumCSS-default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-vertical/ReadiumCSS-after.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-vertical/ReadiumCSS-before.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/cjk-vertical/ReadiumCSS-default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
14 changes: 13 additions & 1 deletion css/dist/rtl/ReadiumCSS-after.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down Expand Up @@ -357,6 +357,18 @@ body{
text-indent:0 !important;
}

:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h1,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h2,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h3,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h4,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h5,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] h6,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] p,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] li,
:root[style*="readium-advanced-on"][style*="--USER__wordSpacing"] div{
word-spacing:var(--USER__wordSpacing);
}

:root[style*="readium-advanced-on"][style*="--USER__arabicLigatures"]{
font-variant-ligatures:var(--USER__ligatures) !important;
}
Expand Down
2 changes: 1 addition & 1 deletion css/dist/rtl/ReadiumCSS-before.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
2 changes: 1 addition & 1 deletion css/dist/rtl/ReadiumCSS-default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Readium CSS (v. 2.0.0-alpha.4)
* Readium CSS (v. 2.0.0-alpha.5)
* Developers: Jiminy Panoz
* Copyright (c) 2017. Readium Foundation. All rights reserved.
* Use of this source code is governed by a BSD-style license which is detailed in the
Expand Down
1 change: 1 addition & 0 deletions css/src/ReadiumCSS-after-rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
@import "modules/user-settings-submodules/ReadiumCSS-lineHeight_pref.css";
@import "modules/user-settings-submodules/ReadiumCSS-paraSpacing_pref.css";
@import "modules/user-settings-submodules/ReadiumCSS-paraIndent_pref.css";
@import "modules/user-settings-submodules/ReadiumCSS-wordSpacing_pref.css";
@import "modules/user-settings-submodules/ReadiumCSS-arabicLigatures_pref.css";
@import "modules/user-settings-submodules/ReadiumCSS-variableFont_pref.css";
@import "modules/ReadiumCSS-fs_normalize.css";
2 changes: 1 addition & 1 deletion docs/CSS06-stylesheets_order.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The following modules must be appended after the author’s stylesheets (`Readiu
9. `ReadiumCSS-lineHeight_pref.css`
10. `ReadiumCSS-paraSpacing_pref.css` (or `ReadiumCSS-paraSpacing-vertical_pref.css` for CJK – vertical writing mode)
11. `ReadiumCSS-paraIndent_pref.css` (does not apply to CJK scripts)
12. `ReadiumCSS-wordSpacing_pref.css` (does not apply to RTL and CJK scripts)
12. `ReadiumCSS-wordSpacing_pref.css` (does not apply to CJK scripts)
13. `ReadiumCSS-letterSpacing_pref.css` (does not apply to RTL scripts, except in vertical writing mode)
14. `ReadiumCSS-arabicLigatures_pref.css` (RTL only)
15. `ReadiumCSS-variableFont_pref.css` (this contains optical sizing, weight and width prefs)
Expand Down
2 changes: 1 addition & 1 deletion docs/CSS16-internationalization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Several parts of the UI must follow the direction (`rtl`) of the primary languag
- user settings e.g. text align;
- implementers might want to localize the interface based on the language set at the system level, or at least fall back to English.

Moreover, some user settings should be removed if used (`letter-` and `word-spacing`) and another one added (arabic ligatures in `ar` and `fa`).
Moreover, some user settings should be removed if used (`letter-spacing`) and another one added (arabic ligatures in `ar` and `fa`).

#### CJK

Expand Down
Binary file modified docs/ReadiumCSS_docs.epub
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/ReadiumCSS_docs/OEBPS/Text/Section-006.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@

<li><code>ReadiumCSS-paraIndent_pref.css</code> (does not apply to CJK scripts)</li>

<li><code>ReadiumCSS-wordSpacing_pref.css</code> (does not apply to RTL and CJK scripts)</li>
<li><code>ReadiumCSS-wordSpacing_pref.css</code> (does not apply to CJK scripts)</li>

<li><code>ReadiumCSS-letterSpacing_pref.css</code> (does not apply to RTL scripts, except in vertical writing mode)</li>

Expand Down
2 changes: 1 addition & 1 deletion docs/ReadiumCSS_docs/OEBPS/Text/Section-016.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@
<li>implementers might want to localize the interface based on the language set at the system level, or at least fall back to English.</li>
</ul>

<p>Moreover, some user settings should be removed if used (<code>letter-</code> and <code>word-spacing</code>) and another one added (arabic ligatures in <code>ar</code> and <code>fa</code>).</p>
<p>Moreover, some user settings should be removed if used (<code>letter-spacing</code>) and another one added (arabic ligatures in <code>ar</code> and <code>fa</code>).</p>
</section>

<section id="cjk" class="level4">
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "readium-css",
"description": "A set of reference stylesheets for EPUB Reading Systems",
"version": "2.0.0-alpha.4",
"version": "2.0.0-alpha.5",
"homepage": "https://github.com/readium/readium-css",
"license": "BSD-3-Clause",
"keywords": [
Expand Down