Upgrade AccessibleDfa to 1.7#123
Merged
Merged
Conversation
Member
|
fixes #56 |
aferditamuriqi
approved these changes
Feb 2, 2023
Member
Author
|
Does anyone have the permissions to merge this? cc @aferditamuriqi @danielweck |
Member
i don't , sorry |
Member
|
@mickael-menu looks like only Jiminy has write access, but we can ask @llemeurfr to add someone to that team https://github.com/orgs/readium/teams/readium-css-committers |
Member
|
let's go! (I checked the PR contents but didn't actually test it) |
Member
Author
|
Thanks Daniel |
danielweck
added a commit
to edrlab/r2-navigator-js
that referenced
this pull request
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
Upgrade the embedded AccessibleDfa font files to fix an issue with some glyphs always displayed with a black color. I took this opportunity to add the italic and bold variants as well.
What is the current behaviour? (You can also link to an open issue here)
When switching on the night theme, the commas are disappearing (they stay black).
What is the new behaviour?
AccessibleDfa 1.7 fixes the issue.