theme in a publication does not apply everywhere

[panaC]

H.+G.+Wells+-+The+Time+Machine.epub.zip

[JayPanoz]

Ah right so unlike night mode, sepia mode doesn’t override background-color.

So the following is not used in sepia mode:

https://github.com/readium/readium-css/blob/14f10444f43c60b4e74aca1bc2f7b4f597305c5e/css/src/modules/ReadiumCSS-night_mode.css#L26-L30

The assumption was that it’s a light mode close to the default enough that asides with background-color could be preserved – e.g. O’Reilly books, but relevant in non-fiction more generally, cf. Kindle implementing a conversion process just for this in their pipeline.

I’m not sure what the best option is though, as by fixing this issue, we will automatically lose this nuance in non-fiction.

Note: I’m also wondering how this renders in night mode in both apps, since background-color is used to hide the border so if you transparentize the background, borders will be displayed.

[panaC]

ok, thanks, to follow

[JayPanoz]

Ah thanks so I’ll have to fix that in night mode also.

Otherwise, I guess it would help to gather opinions on the following:

The assumption was that it’s a light mode close to the default enough that asides with background-color could be preserved – e.g. O’Reilly books, but relevant in non-fiction more generally, cf. Kindle implementing a conversion process just for this in their pipeline.

I’m not sure what the best option is though, as by fixing this issue, we will automatically lose this nuance in non-fiction.

So @llemeurfr and @danielweck for instance, since they were in the original issue. :-)

[llemeurfr]

Hi @JayPanoz, for sure, the iBooks rendering of this specific book (from Feedbooks) is far better. And we know that many publishers are using iBooks as a reference for finalizing their EPUBs.

So I would be inclined to follow their choice and override background colors when themes are active, which would be better for accessibility purpose IMO.

[JayPanoz]

Thanks!

It is my understanding too that sepia mode may be used quite a lot in dys so a11y is one of my concerns.

[JayPanoz]

@panaC I pushed fixes to the reading-mode-improvements branch so ReadiumCSS-after has been updated in dist (for all versions).

See diff.

Looks OK here but can you please confirm it’s also the case on your end before I merge on develop/master?

@danielweck I also updated highlights (re #65) i.e. putting them at the very end of the after stylesheet, adding selectors for sepia/night-mode + !important. Comments/review greatly appreciated, although not urgent by any means.

[danielweck]

I will create a special / temporary build of r2-navigator-js in order to test the ReadiumCSS branch from r2-testapp-js. Once the sepia mode is confirmed to override the background (which it now should, just based on reading Jiminy's CSS code changes), then ReadiumCSS can be updated/published officially, and r2-navigator-js can reference the correct / merged ReadiumCSS Git revision hash.

[JayPanoz]

@panaC @danielweck Yikes, sorry for the delay, just emerging now and I can see the last comment was made on August, 5.

Is the fix OK? It’s been sitting in a branch for months now and should probably be merged into production.

[danielweck]

Good point ... I need to revisit this! (will report back)

[JayPanoz]

Thanks.

And just to be sure as I edited my previous comment, the fix is in the reading-mode-improvements branch https://github.com/readium/readium-css/tree/reading-mode-improvements (and not staging)

[danielweck]

Alll good, thanks Jiminy! :)

[JayPanoz]

Thanks for the confirmation, I will merge into develop first, in order to resolve #58 as well, then merge into master as alpha-3.