Consistent pipe() semantics for closed and closing streams#71
Merged
clue merged 4 commits intoreactphp:masterfrom Mar 6, 2017
Merged
Consistent pipe() semantics for closed and closing streams#71clue merged 4 commits intoreactphp:masterfrom
clue merged 4 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Mar 6, 2017
jsor
reviewed
Mar 6, 2017
README.md
Outdated
| destination can handle. | ||
| * `pipe(WritableStreamInterface $dest, array $options = [])`: | ||
|
|
||
| Pipe all the data from this readable source into the given writable $dest. |
Member
Author
|
Updated to fix typo |
WyriHaximus
approved these changes
Mar 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pipe()method previously showed some inconsistent behavior depending on which side of the pipe closed at which time (prior to piping or during piping).The
pipe()method now shows consistent behavior of callingpause()on the source side if the target is saturated or closed and now cleanly removes the event forwarding if either side is closed.This should not affect normal usage, but some of the more hidden scenarios may in fact rely on the previous behavior. As such, I'm marking this as a BC break just to be safe.
If you want to review, also consider looking at the individual commits, this should make the changes more obvious.
Fixes / closes #36
Builds on top of #70