Add optional $writeChunkSize parameter for max number of bytes to write#105
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom May 19, 2017
Merged
Conversation
Member
Author
|
Unrelated HHVM test failure is being addressed via #106 |
This was referenced May 19, 2017
|
Are you sure that works around the issue? |
Member
Author
This PR is merely a new feature for the stream component :-) Among others, this can be used to work around the issue mentioned in #105, which actually happens in the socket component. I do not think that this "fixes" the issue, but we've seen cases where this can be used to work around this issue and we have yet to spot any issues with this work around. This seems to suggest it's well worth a try 👍 That being said, we strongly encourage people to update PHP to the latest versions, which will ultimately fix this issue altogether 👍 |
WyriHaximus
approved these changes
May 19, 2017
jsor
approved these changes
May 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements the
$readChunkSizethat is available for the readable side of streams.Among others, this can be used to work-around the TLS stream write issues for chunks larger than ~30KB mentioned in #64.