Improve error messages for failed connections#270
Merged
WyriHaximus merged 6 commits intoreactphp:masterfrom Sep 3, 2021
Merged
Improve error messages for failed connections#270WyriHaximus merged 6 commits intoreactphp:masterfrom
WyriHaximus merged 6 commits intoreactphp:masterfrom
Conversation
Member
Author
|
Updated to fix the build error on PHP < 7.4 by cleaning up any garbage memory references as also done in reactphp/dns#118 and reactphp/dns#160. This is now ready for review |
WyriHaximus
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves error messages for failed connections. In particular, failed TCP/IP connections using the happy eyeballs connector (the default) or the old DNS connector will now report the hostname once at the beginning of the message and will not show its internal hostname parameter multiple times:
Likewise, we now make sure to always consistently include the URI scheme used in the error message. For instance, failed TLS connections will now include the appropriate URI scheme for the start of the message and show the underlying URI scheme for underlying TCP/IP connection issues such as this:
Builds on top of #265, #266, #267 and others such as clue/reactphp-redis#116, friends-of-reactphp/mysql#141 and more