Fix cancelling happy eyeballs to stop timer, fix rejection reason and simplify timer logic#225
Merged
jsor merged 2 commits intoreactphp:masterfrom Mar 11, 2020
Merged
Conversation
WyriHaximus
approved these changes
Mar 11, 2020
jsor
approved these changes
Mar 11, 2020
This was referenced May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes a leftover timer reference when cancelling the happy eyeballs connection attempt. Additionally, this increases test coverage to 100% and significantly improves test times (27s->5s).
Builds on top of #224