Trigger an E_USER_ERROR instead of throwing an exception from done()#97
Merged
jsor merged 1 commit intoreactphp:masterfrom Sep 19, 2017
Merged
Trigger an E_USER_ERROR instead of throwing an exception from done()#97jsor merged 1 commit intoreactphp:masterfrom
jsor merged 1 commit intoreactphp:masterfrom
Conversation
If an error (either a thrown exception or returned rejection) escapes the done() callbacks, it will now cause a fatal error by using trigger_error() with E_USER_ERROR instead of (re)throwing. Because promise resolution is synchronous, those exceptions bubbled up to the reject() call which mixed resolution and consumption parts.
WyriHaximus
approved these changes
Sep 10, 2017
clue
approved these changes
Sep 19, 2017
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an error (either a thrown exception or returned rejection) escapes the
done()callbacks, it will now cause a fatal error by usingtrigger_error()withE_USER_ERRORinstead of (re)throwing.Because promise resolution is synchronous, those exceptions bubbled up to the
reject()call which mixed resolution and consumption parts.Closes #88