Conversation
Closed
WyriHaximus
approved these changes
Jan 11, 2017
Member
Author
|
Since this PR is approved by @WyriHaximus and @clue is undecided, i'm going to merge this one in the next days (and close #81) if there no any objections. |
clue
requested changes
Jan 13, 2017
Member
clue
left a comment
There was a problem hiding this comment.
I'll keep my vote at +/-0, but I'm tempted to prefer this one because it ensures consistency with ES6 promises.
The changed behavior should be documented in the README (à la bluebird docs), otherwise LGTM 👍
Member
Author
|
@clue Good point, note added. 👍 |
clue
approved these changes
Jan 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
race()to return a forever pending promise when called with an empty array.Alternative for #81.
See #57 for the discussion.
Closes #57