[3.x] feat: add support for DNF types#236
Merged
WyriHaximus merged 2 commits intoreactphp:3.xfrom Sep 14, 2022
nhedger:feat/dnf
Merged
[3.x] feat: add support for DNF types#236WyriHaximus merged 2 commits intoreactphp:3.xfrom nhedger:feat/dnf
WyriHaximus merged 2 commits intoreactphp:3.xfrom
nhedger:feat/dnf
Conversation
SimonFrings
approved these changes
Sep 9, 2022
Member
SimonFrings
left a comment
There was a problem hiding this comment.
@nhedger Looks good to me 👍
WyriHaximus
approved these changes
Sep 14, 2022
Member
WyriHaximus
left a comment
There was a problem hiding this comment.
Awesome, thank you for putting this together 👍
Member
Contributor
Author
|
I'll do it, probably before the end of the week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Disjunctive Normal Form Types (DNF types) when using PHP 8.2.
Overview of the changes
ReflectionNamedTypeto be analyzed.Adds two new internal functionsmatchesTypeandmatchesAllTypesto extract common functionality.Please let me know if you think that I missed something.
Closes #235