Use \Throwable exclusively in rejection function docs#142
Use \Throwable exclusively in rejection function docs#142jsor merged 2 commits intoreactphp:masterfrom
Conversation
Follow-up for 505cf5e.
There was a problem hiding this comment.
The changeset looks reasonable to me, but just one question: Is is common knowledge that Throwable is the base of Exception or should we perhaps make this more explicit? It's my understanding most common use cases would likely reject a promise with a subclass of Exception such as RuntimeException (and family) and it might make sense to keep this as a search keyword in the documentation?
|
Good point, i will try to rework the docs 👍 . But we must make sure to not recommend |
|
I concur, adding |
|
@clue added a short paragraph about |
c1a75d8 to
a747ad4
Compare
a747ad4 to
6a45c24
Compare
clue
left a comment
There was a problem hiding this comment.
Thanks for the update, changes LGTM! 💯
|
🎉 ! |
Follow-up for #138.